Skip to content

refactor(core): simplify persistence boundaries - #43929

Merged
kitlangton merged 3 commits into
v2from
reuse-persistence-primitives
Aug 21, 2026
Merged

refactor(core): simplify persistence boundaries#43929
kitlangton merged 3 commits into
v2from
reuse-persistence-primitives

Conversation

@kitlangton

@kitlangton kitlangton commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What

Simplify persistence and external-data boundaries by reusing canonical connection, filtering, normalization, and narrowing primitives. The refactor removes duplicated implementation while preserving every query, transaction, path, error, and provider-overlay behavior.

How

  • Build the Workerd connection with the same Sqlite.makeConnection helper used by Bun and Node.
  • Share Credential legacy-row filtering between all and list.
  • Express Worktree create/remove results as direct boolean Effect transformations.
  • Normalize ripgrep paths once across glob, find, and grep.
  • Reuse one unknown-to-Error conversion across MCP promise boundaries.
  • Use the canonical AI package isRecord guard for provider overlays.

Scope

Behavior-preserving Core cleanup only; no schema, migration, transaction, path policy, MCP recovery, provider merge, or public API changes.

Testing

  • Persistence tests: 23 passed
  • Ripgrep, MCP, and provider tests: 38 passed
  • Simplify follow-up: bun run test test/ripgrep.test.ts (6 passed)
  • bun typecheck from packages/core
  • Push hook: bun turbo typecheck --concurrency=3 (40-package workspace)

@kitlangton kitlangton changed the title refactor(core): reuse persistence primitives refactor(core): simplify persistence boundaries Aug 21, 2026
@kitlangton
kitlangton enabled auto-merge (squash) August 21, 2026 17:37
@kitlangton
kitlangton merged commit 2524e6b into v2 Aug 21, 2026
10 checks passed
@kitlangton
kitlangton deleted the reuse-persistence-primitives branch August 21, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant